ensure parseurl always working as expected

lib/request.js

@@ -127,6 +127,8 @@ module.exports = {
 
   set path(path) {
     const url = parse(this.req);
+    if (url.pathname === path) return;
+
     url.pathname = path;
     url.path = null;
 
@@ -178,6 +180,8 @@ module.exports = {
 
   set querystring(str) {
     const url = parse(this.req);
+    if (url.search === `?${str}`) return;
+
     url.search = str;
     url.path = null;
 

test/request/path.js

@@ -2,6 +2,7 @@
 'use strict';
 
 const context = require('../helpers/context');
+const parseurl = require('parseurl');
 
 describe('ctx.path', () => {
   it('should return the pathname', () => {
@@ -28,4 +29,11 @@ describe('ctx.path=', () => {
     ctx.originalUrl.should.equal('/login');
     ctx.request.originalUrl.should.equal('/login');
   });
+
+  it('should not affect parseurl', () => {
+    const ctx = context({ url: '/login?foo=bar' });
+    ctx.path = '/login';
+    const url = parseurl(ctx.req);
+    url.path.should.equal('/login?foo=bar');
+  });
 });

test/request/querystring.js

@@ -2,6 +2,7 @@
 'use strict';
 
 const context = require('../helpers/context');
+const parseurl = require('parseurl');
 
 describe('ctx.querystring', () => {
   it('should return the querystring', () => {
@@ -44,4 +45,11 @@ describe('ctx.querystring=', () => {
     ctx.originalUrl.should.equal('/store/shoes');
     ctx.request.originalUrl.should.equal('/store/shoes');
   });
+
+  it('should not affect parseurl', () => {
+    const ctx = context({ url: '/login?foo=bar' });
+    ctx.querystring = 'foo=bar';
+    const url = parseurl(ctx.req);
+    url.path.should.equal('/login?foo=bar');
+  });
 });