From 0df400fa60a5b7845c2127585453e175bdf30a08 Mon Sep 17 00:00:00 2001 From: Slobodan Stojanovic Date: Sat, 24 Oct 2015 16:19:56 +0200 Subject: [PATCH 1/2] Refactor application.js - use arrow function in callback --- lib/application.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/application.js b/lib/application.js index 833b582..fbea4a4 100644 --- a/lib/application.js +++ b/lib/application.js @@ -115,9 +115,7 @@ module.exports = class Application extends Emitter { res.statusCode = 404; const ctx = this.createContext(req, res); onFinished(res, ctx.onerror); - fn(ctx).then(function() { - respond(ctx); - }).catch(ctx.onerror); + fn(ctx).then(() => respond(ctx)).catch(ctx.onerror); }; } From dac250b3af3ea5bb5f50eda1d0103c75e8792798 Mon Sep 17 00:00:00 2001 From: Slobodan Stojanovic Date: Sat, 24 Oct 2015 17:30:25 +0200 Subject: [PATCH 2/2] Refactor - EventEmitter is already exported by 'events' module The 'events' module already exports 'EventEmitter' constructor function - https://github.com/nodejs/node/pull/2921 --- lib/application.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/application.js b/lib/application.js index fbea4a4..c3edd5a 100644 --- a/lib/application.js +++ b/lib/application.js @@ -7,7 +7,7 @@ const isGeneratorFunction = require('is-generator-function'); const debug = require('debug')('koa:application'); -const Emitter = require('events').EventEmitter; +const Emitter = require('events'); const onFinished = require('on-finished'); const response = require('./response'); const compose = require('koa-compose');