TheThing/koa-lite
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix: Status message is not supported on HTTP/2 (#1264)

Browse source
This commit is contained in:
André Cruz 2018-11-09 17:41:21 +00:00 committed by Yiyu He
parent 71aaa29591
commit 99051992a9
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/application.js
View file

@ -222,7 +222,11 @@ function respond(ctx) {
// status body // status body
if (null == body) { if (null == body) {
if (ctx.req.httpVersionMajor >= 2) {
body = String(code);
} else {
body = ctx.message || String(code); body = ctx.message || String(code);
}
if (!res.headersSent) { if (!res.headersSent) {
ctx.type = 'text'; ctx.type = 'text';
ctx.length = Buffer.byteLength(body); ctx.length = Buffer.byteLength(body);

12
test/application/response.js
View file

@ -9,6 +9,7 @@ describe('app.response', () => {
const app1 = new Koa(); const app1 = new Koa();
app1.response.msg = 'hello'; app1.response.msg = 'hello';
const app2 = new Koa(); const app2 = new Koa();
const app3 = new Koa();
it('should merge properties', () => { it('should merge properties', () => {
app1.use((ctx, next) => { app1.use((ctx, next) => {
@ -31,4 +32,15 @@ describe('app.response', () => {
.get('/') .get('/')
.expect(204); .expect(204);
}); });
it('should not include status message in body for http2', async () => {
app3.use((ctx, next) => {
ctx.req.httpVersionMajor = 2;
ctx.status = 404;
});
const response = await request(app3.listen())
.get('/')
.expect(404);
assert.equal(response.text, '404');
});
}); });