TheThing/koa-lite
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix: subdomains should be [] if the host is an ip (#807)

Browse source 
* fix: subdomains should be [] if the host is an ip

Fixes #775
This commit is contained in:
Adam Lau 2016-09-07 11:23:39 +08:00 committed by Yiyu He
parent 1aa85ce721
commit b1a14f1a73
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/request.js
View file

@ -5,6 +5,7 @@
* Module dependencies. * Module dependencies.
*/ */
var net = require('net');
var contentType = require('content-type'); var contentType = require('content-type');
var stringify = require('url').format; var stringify = require('url').format;
var parse = require('parseurl'); var parse = require('parseurl');
@ -417,7 +418,9 @@ module.exports = {
get subdomains() { get subdomains() {
var offset = this.app.subdomainOffset; var offset = this.app.subdomainOffset;
return (this.host || '') var host = this.host || '';
if (net.isIP(host)) return [];
return host
.split('.') .split('.')
.reverse() .reverse()
.slice(offset); .slice(offset);

8
test/request/subdomains.js
View file

@ -14,8 +14,14 @@ describe('req.subdomains', function(){
req.subdomains.should.eql(['tobi']); req.subdomains.should.eql(['tobi']);
}) })
describe('with no host present', function(){ it('should work with no host present', function(){
var req = request(); var req = request();
req.subdomains.should.eql([]); req.subdomains.should.eql([]);
}) })
it('should check if the host is an ip address', function(){
var req = request();
req.header.host = '127.0.0.1';
req.subdomains.should.eql([]);
});
}) })