TheThing/koa-lite
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix malformed content-type header causing exception on charset get (#897)

Browse source
This commit is contained in:
Rui Marinho 2017-02-11 16:02:53 +00:00 committed by Yiyu He
parent 948d3efaf6
commit d28d959bc8
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/request.js
View file

@ -319,7 +319,13 @@ module.exports = {
var type = this.get('Content-Type'); var type = this.get('Content-Type');
if (!type) return ''; if (!type) return '';
return contentType.parse(type).parameters.charset || ''; try {
type = contentType.parse(type);
} catch (e) {
return '';
}
return type.parameters.charset || '';
}, },
/** /**

6
test/request/charset.js
View file

@ -26,5 +26,11 @@ describe('req.charset', function(){
req.header['content-type'] = 'text/plain; charset=utf-8'; req.header['content-type'] = 'text/plain; charset=utf-8';
req.charset.should.equal('utf-8'); req.charset.should.equal('utf-8');
}) })
it('should return "" if content-type is invalid', function(){
var req = request();
req.header['content-type'] = 'application/json; application/text; charset=utf-8';
req.charset.should.equal('');
})
}) })
}) })