Commit graph

190 commits

Author SHA1 Message Date
Jonathan Ong
01dd6a33c5 context: delegate etag/last-modified 2014-06-05 16:19:29 -07:00
Jonathan Ong
008f0554c6 set-type -> mime-types
removes mime dependencies from the dep tree.
liberally sets charset because some express users complained about bad
browsers using the default charset.
2014-06-03 21:44:25 -07:00
dead_horse
f76268ba58 remove req.host=, fix docs 2014-05-05 12:45:33 +08:00
TJ Holowaychuk
1d9a0e1d31 ocd 2014-05-02 12:21:55 -07:00
Yazhong Liu
b969ecf223 request: complete idempotent methods
see rfc2616: http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.1.

Intact idempotent HTTP methods should be:
GET, HEAD, PUT, DELETE, OPTIONS and TRACE
2014-05-03 02:56:08 +08:00
TJ Holowaychuk
c16211c5d6 refactor 2014-05-01 17:46:09 -07:00
TJ Holowaychuk
f17629d19f remove .outputErrors, suppress output when handled by the dev. Closes 2014-05-01 16:29:37 -07:00
TJ Holowaychuk
4ff54e5c13 ocd 2014-05-01 16:25:08 -07:00
TJ Holowaychuk
80ace2c0bb add nicer error formatting 2014-05-01 16:18:40 -07:00
TJ Holowaychuk
15ab936001 change .status default to 404. Closes 2014-04-28 21:17:46 -07:00
dead_horse
48ac0669c5 fix content-length when body is re-assigned. Closes 2014-04-28 20:34:26 -07:00
TJ Holowaychuk
952dca336d rename setType -> getType
sounds weird
2014-04-28 20:12:53 -07:00
Jonathan Ong
163e59c0d5 refactor to use set-type 2014-04-27 01:53:07 -07:00
Jonathan Ong
0cacc5706a use koa-is-json 2014-04-25 00:15:33 -07:00
TJ Holowaychuk
94dd87741e ocd 2014-04-24 17:58:37 -07:00
dead_horse
6a2ed3e6eb assert object type in ctx.onerror 2014-04-25 08:34:11 +08:00
dead_horse
5de9d962a0 remove unused debug 2014-04-25 00:07:37 +08:00
Jonathan Ong
e472a18010 refactor: use mime-extended 2014-04-19 07:45:57 -07:00
TJ Holowaychuk
74cb04e7c1 refactor 2014-04-15 08:39:40 -07:00
TJ Holowaychuk
0a954c8d99 ocd 2014-04-15 08:35:10 -07:00
dead_horse
b06bb3cb85 simplify respond 2014-04-15 23:31:11 +08:00
TJ Holowaychuk
990caf4e71 refactor 2014-04-14 15:36:39 -07:00
TJ Holowaychuk
95a78c3a44 Merge pull request from dead-horse/stream-body
make sure all intermediate stream bodies will be destroy
2014-04-14 15:34:13 -07:00
dead_horse
69c82f63b5 fix length when .body is missing 2014-04-13 11:35:28 +08:00
TJ Holowaychuk
bb0a0b3659 ocd 2014-04-12 10:59:04 -07:00
dead_horse
64aad129d3 fix this.status= in this.body
fix default status set bug in this.body=null.
do not call this.status= if this.status exist.
make sure empty content status remove content headers
2014-04-10 11:47:30 +08:00
TJ Holowaychuk
3d8ab61fa1 change res.type= to always default charset. Closes 2014-04-09 09:34:50 -07:00
dead_horse
329d2b94db make sure all intermediate stream bodies will be destroy and have error handle 2014-04-10 00:02:13 +08:00
TJ Holowaychuk
dfe8e95be4 remove ctx.inspect() implementation. Closes
obscures user-defned properties. ideally we fix it so .req / .res are not so verbose but meh for now
2014-04-05 19:15:14 -07:00
Dmitry Mazuro
9e8d6a3aa0 ocd 2014-03-24 21:21:15 +03:00
Jonathan Ong
52cb57cc7e fix overwriting of content-type w/ HEAD requests 2014-03-23 04:01:14 -07:00
Jonathan Ong
c382305d4f refactor: use escape-html
dat SLOC
2014-03-12 18:30:16 -07:00
Jonathan Ong
182f9d6fa4 refactor: use statuses 2014-03-12 18:29:14 -07:00
TJ Holowaychuk
9b1651a8e6 fix inspection of app. Closes 2014-03-11 11:06:57 -07:00
TJ Holowaychuk
895cf4040c add app.toJSON() 2014-03-11 11:01:33 -07:00
New Now Nohow
0a223f2bb7 Let errors provide their own status.
When calling `ctx.throw`, you're allowed to provide an error object and a
status code. The status code is later set as the `status` property of the error
object. If no status code is provided, it defaults to 500. However, this
happens even if the error object already had a `status` property.

This commit allows an error's pre-existing `status` property to be used in
conjunction with `ctx.throw`.

If the status code is below 500, the error message will be exposed to the user
in the HTTP response. It would be nice to have some Error subclasses that
always have the same status code, because then we could just write
`ctx.throw(new WhateverError())`, and define which 4xx error code we want in
the definition of `WhateverError` itself. If, for example, an
`AuthenticationError` is always meant to go along with a 401, then it would be
nice to just have that knowledge in the class definition.
2014-03-06 22:54:25 -05:00
TJ Holowaychuk
b1f0abd16d Revert "add response.charset accessor and ctx.charset alias"
This reverts commit 94413b1bd4.
2014-03-06 18:05:01 -08:00
TJ Holowaychuk
c50012a636 Merge pull request from dead-horse/issue224-host-confused
add request.hostname(getter), fixed 
2014-02-26 10:54:40 -08:00
Robert Sköld
e77e5a4bdc Debug name koa:context -> koa:request 2014-02-26 09:51:45 +01:00
dead_horse
72a9b69146 add request.hostname(getter), fixed
make request.host and request.hostname work as node url lib
http://nodejs.org/api/url.html#url_url
this commit will change older request.host(getter)
2014-02-26 14:03:05 +08:00
Jonathan Ong
cb532b7bef this.writable to check if the socket is writable
because node sucks haha
2014-02-15 02:06:08 -08:00
TJ Holowaychuk
785aba879c add request.charset 2014-02-14 09:38:59 -08:00
TJ Holowaychuk
94413b1bd4 add response.charset accessor and ctx.charset alias 2014-02-14 09:33:10 -08:00
TJ Holowaychuk
08149052fa change ctx.length and ctx.type to always delegate to response object [breaking change] 2014-02-14 09:16:39 -08:00
Jonathan Ong
c7ff0e2ac1 response.body: fix html content sniffing for strings
closes 
2014-02-13 18:35:25 -08:00
TJ Holowaychuk
aa08845c70 remove app.jsonSpaces setting. Closes 2014-01-31 18:39:47 -08:00
Jonathan Ong
ea5757ff57 remove app.keys getter/setter
closes 
2014-01-31 16:09:29 -08:00
Jonathan Ong
c5655e093a bump cookies to 0.4.0
no longer need to do that keygrip stuff, though i’m more inclined to
remove all the error checking.
2014-01-31 13:52:27 -08:00
TJ Holowaychuk
3a50280445 Merge pull request from koajs/fix/ctx.onerror
context.onerror: fix response handling
2014-01-24 15:03:02 -08:00
Jonathan Ong
2bc3bb7327 this.respond=false for bypassing koa's response handling
closes 
2014-01-24 14:38:40 -08:00