TheThing/nconf-lite
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

allow storing null in redis

Browse source
This commit is contained in:
Sami Samhuri 2011-05-22 12:32:03 -07:00
parent faa8ab9486
commit 6acc1fc533
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/nconf/stores/redis.js
View file

@ -151,7 +151,7 @@ Redis.prototype.set = function (key, value, callback) {
var fullKey = nconf.key(self.namespace, key); var fullKey = nconf.key(self.namespace, key);
if (!Array.isArray(value) && typeof value === 'object') { if (!Array.isArray(value) && value !== null && typeof value === 'object') {
// //
// If the value is an `Object` (and not an `Array`) then // If the value is an `Object` (and not an `Array`) then
// nest into the value and set the child keys appropriately. // nest into the value and set the child keys appropriately.

16
test/redis-store-test.js
View file

@ -37,6 +37,14 @@ vows.describe('nconf/stores/redis').addBatch({
"should respond without an error": function (err, ok) { "should respond without an error": function (err, ok) {
assert.isNull(err); assert.isNull(err);
} }
},
"with null": {
topic: function (store) {
store.set('falsy:object', null, this.callback);
},
"should respond without an error": function(err, ok) {
assert.isNull(err);
}
} }
} }
} }
@ -75,6 +83,14 @@ vows.describe('nconf/stores/redis').addBatch({
"should respond with the correct value": function (err, value) { "should respond with the correct value": function (err, value) {
assert.deepEqual(value, data.obj.auth); assert.deepEqual(value, data.obj.auth);
} }
},
"with null": {
topic: function(store) {
store.get('falsy:object', this.callback);
},
"should respond with the correct value": function(err, value) {
assert.equal(value, null);
}
} }
} }
} }