TheThing/nconf-lite
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Don't do array lookups on strings. (#188)

Browse source 
`hasOwnProperty(number)` can return true for strings.

This is unlikely to be the desired usage, and can mean that odd
responses are returned by nconf.

Disable trying to check `hasOwnProperty` of strings.
This commit is contained in:
bryce-gibson 2017-11-05 12:39:00 +11:00 committed by Matt Hamann
parent 467ab753c8
commit b6699aba2d
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/nconf/stores/memory.js
View file

@ -44,7 +44,7 @@ Memory.prototype.get = function (key) {
// //
while (path.length > 0) { while (path.length > 0) {
key = path.shift(); key = path.shift();
if (target && target.hasOwnProperty(key)) { if (target && typeof target !== 'string' && target.hasOwnProperty(key)) {
target = target[key]; target = target[key];
continue; continue;
} }

3
test/nconf-test.js
View file

@ -67,6 +67,9 @@ vows.describe('nconf').addBatch({
"without a callback": { "without a callback": {
"should respond with the correct value": function () { "should respond with the correct value": function () {
assert.equal(nconf.get('foo:bar:bazz'), 'buzz'); assert.equal(nconf.get('foo:bar:bazz'), 'buzz');
},
"should not step inside strings": function () {
assert.equal(nconf.get('foo:bar:bazz:0'), undefined);
} }
}, },
"with a callback": { "with a callback": {