From faa8ab948674c43a31c8b8c53a6db4ebf12ac5a5 Mon Sep 17 00:00:00 2001
From: Sami Samhuri <sami.samhuri@gmail.com>
Date: Sun, 22 May 2011 12:30:19 -0700
Subject: [PATCH] correctly retrieve falsy values from memory (hence file)

---
 lib/nconf/stores/memory.js | 2 +-
 test/file-store-test.js    | 8 ++++++++
 test/memory-store-test.js  | 8 ++++++++
 3 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/lib/nconf/stores/memory.js b/lib/nconf/stores/memory.js
index 74b5520..b4cbe9b 100644
--- a/lib/nconf/stores/memory.js
+++ b/lib/nconf/stores/memory.js
@@ -36,7 +36,7 @@ Memory.prototype.get = function (key) {
   //
   while (path.length > 0) {
     key = path.shift();
-    if (!target[key]) {
+    if (!(target && key in target)) {
       return;
     }
     
diff --git a/test/file-store-test.js b/test/file-store-test.js
index 7a020ac..c66301f 100644
--- a/test/file-store-test.js
+++ b/test/file-store-test.js
@@ -63,11 +63,19 @@ vows.describe('nconf/stores/file').addBatch({
     "the set() method": {
       "should respond with true": function () {
         assert.isTrue(store.set('foo:bar:bazz', 'buzz'));
+        assert.isTrue(store.set('falsy:number', 0));
+        assert.isTrue(store.set('falsy:string', ''));
+        assert.isTrue(store.set('falsy:boolean', false));
+        assert.isTrue(store.set('falsy:object', null));
       }
     },
     "the get() method": {
       "should respond with the correct value": function () {
         assert.equal(store.get('foo:bar:bazz'), 'buzz');
+        assert.equal(store.get('falsy:number'), 0);
+        assert.equal(store.get('falsy:string'), '');
+        assert.equal(store.get('falsy:boolean'), false);
+        assert.equal(store.get('falsy:object'), null);
       }
     },
     "the clear() method": {
diff --git a/test/memory-store-test.js b/test/memory-store-test.js
index 57c6244..a0a3f8f 100644
--- a/test/memory-store-test.js
+++ b/test/memory-store-test.js
@@ -15,11 +15,19 @@ vows.describe('nconf/stores/memory').addBatch({
     "the set() method": {
       "should respond with true": function (store) {
         assert.isTrue(store.set('foo:bar:bazz', 'buzz'));
+        assert.isTrue(store.set('falsy:number', 0));
+        assert.isTrue(store.set('falsy:string', ''));
+        assert.isTrue(store.set('falsy:boolean', false));
+        assert.isTrue(store.set('falsy:object', null));
       }
     },
     "the get() method": {
       "should respond with the correct value": function (store) {
         assert.equal(store.get('foo:bar:bazz'), 'buzz');
+        assert.equal(store.get('falsy:number'), 0);
+        assert.equal(store.get('falsy:string'), '');
+        assert.equal(store.get('falsy:boolean'), false);
+        assert.equal(store.get('falsy:object'), null);
       }
     },
     "the clear() method": {