From 3be145a72c490ffc81b94951d371f11f297f288f Mon Sep 17 00:00:00 2001 From: Trent Mick Date: Sun, 16 Aug 2015 17:51:30 -0700 Subject: [PATCH] drop 0.8 support; test with iojs3.0 (tho it is broken) --- CHANGES.md | 5 ++++- Makefile | 34 +++++++++++++--------------------- package.json | 4 ++-- 3 files changed, 19 insertions(+), 24 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index a769fc8..804a6cc 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -8,7 +8,10 @@ Known issues: ## bunyan 1.4.1 (not yet released) -(nothing yet) +- Dropped support for 0.8 (can't install deps easily anymore for running + test suite). Bump to a recent iojs version for testing (though really + they move too fast). Note that dtrace-provider build fails for iojs v3.0 + right now. :| ## bunyan 1.4.0 diff --git a/Makefile b/Makefile index 082f3ca..73675c2 100644 --- a/Makefile +++ b/Makefile @@ -87,23 +87,20 @@ test: $(NODEUNIT) # Note: 'test10' is last so (if all is well) I end up with a binary # dtrace-provider build for node 0.10 (my current version). .PHONY: testall -testall: test22 test20 test18 test012 test08 test010 +testall: testiojs30 test012 test010 -.PHONY: test22 -test22: - @echo "# Test iojs 2.2.x (with node `$(NODEOPT)/iojs-v2.2/bin/node --version`)" - @$(NODEOPT)/iojs-v2.2/bin/node --version | grep '^v2\.2\.' - #PATH="$(NODEOPT)/iojs-v2.2/bin:$(PATH)" make distclean all test -.PHONY: test20 -test20: - @echo "# Test iojs 2.0.x (with node `$(NODEOPT)/iojs-v2.0/bin/node --version`)" - @$(NODEOPT)/iojs-v2.0/bin/node --version | grep '^v2\.0\.' - PATH="$(NODEOPT)/iojs-v2.0/bin:$(PATH)" make distclean all test -.PHONY: test18 -test18: - @echo "# Test iojs 1.8.x (with node `$(NODEOPT)/iojs-v1.8/bin/node --version`)" - @$(NODEOPT)/iojs-v1.8/bin/node --version | grep '^v1\.8\.' - PATH="$(NODEOPT)/iojs-v1.8/bin:$(PATH)" make distclean all test +.PHONY: testalliojs +testalliojs: + ls -d $(NODEOPT)/iojs-?.? | while read dir; do \ + echo; \ + echo "# Test $$dir (`$$dir/bin/node --version`)"; \ + PATH="$$dir/bin:$(PATH)" make distclean all test; \ + done + +.PHONY: testiojs30 +testiojs30: + @echo "# Test iojs 3.0 (`$(NODEOPT)/iojs-3.0/bin/node --version`)" + PATH="$(NODEOPT)/iojs-3.0/bin:$(PATH)" make distclean all test .PHONY: test012 test012: @echo "# Test node 0.12.x (with node `$(NODEOPT)/node-0.12/bin/node --version`)" @@ -114,11 +111,6 @@ test010: @echo "# Test node 0.10.x (with node `$(NODEOPT)/node-0.10/bin/node --version`)" @$(NODEOPT)/node-0.10/bin/node --version | grep '^v0\.10\.' PATH="$(NODEOPT)/node-0.10/bin:$(PATH)" make distclean all test -.PHONY: test08 -test08: - @echo "# Test node 0.8.x (with node `$(NODEOPT)/node-0.8/bin/node --version`)" - @$(NODEOPT)/node-0.8/bin/node --version | grep '^v0\.8\.' - PATH="$(NODEOPT)/node-0.8/bin:$(PATH)" make distclean all test #---- check diff --git a/package.json b/package.json index 38476ee..d8be1da 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ "type": "git", "url": "git://github.com/trentm/node-bunyan.git" }, - "engines": ["node >=0.8.0"], + "engines": ["node >=0.10.0"], "keywords": ["log", "logging", "log4j", "json", "bunyan"], "// comment1": "'dtrace-provider' required for dtrace features", @@ -23,7 +23,7 @@ "safe-json-stringify": "~1" }, "devDependencies": { - "nodeunit": "0.9.*", + "nodeunit": "0.9", "ben": "0.0.0", "verror": "1.3.3", "vasync": "1.4.3"