TheThing/node-bunyan-lite
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Wiki Activity

improve crash message

Browse source
This commit is contained in:
Trent Mick 2012-10-21 16:23:46 -07:00
parent 1844dfd062
commit a8279bd90d
2 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGES.md
View file

@ -2,7 +2,8 @@
## bunyan 0.14.6 (not yet released) ## bunyan 0.14.6 (not yet released)
(nothing yet) - Improve the crash message to make it easier to provide relevant details in a
bug report.
## bunyan 0.14.5 ## bunyan 0.14.5

16
bin/bunyan
View file

@ -61,6 +61,10 @@ Object.keys(levelFromName).forEach(function (name) {
}); });
// The current raw input line being processed. Used for `uncaughtException`.
var currLine = null;
//---- support functions //---- support functions
@ -478,6 +482,8 @@ function isValidRecord(rec) {
* records) or enqueues it for emitting later when it's the next line to show. * records) or enqueues it for emitting later when it's the next line to show.
*/ */
function handleLogLine(file, line, opts, stylize) { function handleLogLine(file, line, opts, stylize) {
currLine = line; // intentionally global
// Emit non-JSON lines immediately. // Emit non-JSON lines immediately.
var rec; var rec;
if (!line) { if (!line) {
@ -968,17 +974,19 @@ process.on('uncaughtException', function (err) {
return lines.join('\n'); return lines.join('\n');
} }
var title = encodeURIComponent(format(
"Bunyan %s crashed: %s", getVersion(), err.message));
console.error('* * *'); console.error('* * *');
console.error('* The Bunyan CLI crashed! Please report this issue:'); console.error('* The Bunyan CLI crashed! Please report this issue and');
console.error('* include the details below:');
console.error('*'); console.error('*');
console.error('* https://github.com/trentm/node-bunyan/issues/new'); console.error('* https://github.com/trentm/node-bunyan/issues/new?title=%s', title);
console.error('*'); console.error('*');
console.error('* and include the following Bunyan details the log file');
console.error('* (or section of log file) on which the Bunyan CLI crashed.');
console.error('* * *'); console.error('* * *');
console.error('* node version:', process.version); console.error('* node version:', process.version);
console.error('* bunyan version:', getVersion()); console.error('* bunyan version:', getVersion());
console.error('* argv: %j', process.argv); console.error('* argv: %j', process.argv);
console.error('* log line: %j', currLine);
console.error('* stack:'); console.error('* stack:');
console.error(indent(err.stack)); console.error(indent(err.stack));
console.error('* * *'); console.error('* * *');