From b66571f113b136afba9549cdb089462579edfa58 Mon Sep 17 00:00:00 2001 From: Trent Mick Date: Mon, 6 Mar 2017 11:24:11 -0800 Subject: [PATCH] formatting --- TODO.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/TODO.md b/TODO.md index eef780b..000434e 100644 --- a/TODO.md +++ b/TODO.md @@ -7,10 +7,12 @@ # changes to ctor and log.child to separate fields from config Current: + createLogger() log.child(, ) Could be: + createLogger(, ) log.child(, ) # Still support: log.child(, ) @@ -19,11 +21,15 @@ Pros: Compat issues are minimal: a change is only required if there is a collision with used field and a new config var name. Cons: A *slight* con is that my guess is the common usage of child is `log.child()`, so the more future-proof common usage becomes: + log.child(null, ) + That's not too bad. It is clearer at least than: + log.child(, true) TODO: + - is there a ticket for this work already? - make the change - do a migration guide? i.e. provide the grep commands to find all