From cc6a2d0f6e65fb8f551618d551204a75429f9914 Mon Sep 17 00:00:00 2001 From: Dave Pacheco Date: Wed, 20 Jun 2012 10:39:56 -0700 Subject: [PATCH] code review comments --- lib/bunyan.js | 1 - test/ringbuffer.test.js | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/bunyan.js b/lib/bunyan.js index 52b5f99..e32c6ae 100644 --- a/lib/bunyan.js +++ b/lib/bunyan.js @@ -1003,7 +1003,6 @@ RingBuffer.prototype.destroy = function () { RingBuffer.prototype.destroySoon = function () { this.destroy(); - this.emit('close'); }; diff --git a/test/ringbuffer.test.js b/test/ringbuffer.test.js index 8a0329e..beefd3a 100644 --- a/test/ringbuffer.test.js +++ b/test/ringbuffer.test.js @@ -19,17 +19,17 @@ var log1 = new Logger({ test('ringbuffer', function (t) { log1.info('hello'); log1.trace('there'); - log1.error('chucklebucket'); + log1.error('android'); t.equal(ringbuffer.entries.length, 2); t.equal(ringbuffer.entries[0]['msg'], 'hello'); - t.equal(ringbuffer.entries[1]['msg'], 'chucklebucket'); + t.equal(ringbuffer.entries[1]['msg'], 'android'); log1.error('one'); log1.error('two'); log1.error('three'); t.equal(ringbuffer.entries.length, 5); log1.error('four'); t.equal(ringbuffer.entries.length, 5); - t.equal(ringbuffer.entries[0]['msg'], 'chucklebucket'); + t.equal(ringbuffer.entries[0]['msg'], 'android'); t.equal(ringbuffer.entries[1]['msg'], 'one'); t.equal(ringbuffer.entries[2]['msg'], 'two'); t.equal(ringbuffer.entries[3]['msg'], 'three');