TheThing/flaska
1
0
Fork 0
Code Issues Pull requests Projects Releases 20 Wiki Activity Actions

requestEnd: Fix detection on when response is finished

Browse source
This commit is contained in:
Jonatan Nilsson 2021-10-10 21:32:15 +00:00
parent 6fe5a7272d
commit c3b7447024
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
flaska.mjs
View file

@ -467,7 +467,7 @@ export class Flaska {
if (err) {
this._onerror(err, ctx)
}
if (ctx.req.complete) {
if (ctx.res.writableEnded) {
return
}

11
test/flaska.out.test.mjs
View file

@ -198,6 +198,17 @@ t.describe('#requestEnd()', function() {
flaska.requestEnd(null, ctx)
})
t.test('should return immediately if req is finished', function() {
let onFinish = function() {
throw new Error('should not be called')
}
const ctx = createCtx({ }, onFinish)
ctx.res.writableEnded = true
let flaska = new Flaska({}, fakerHttp, fakeStream)
flaska.requestEnd(null, ctx)
})
const emptyStatuses = [204, 205, 304]
emptyStatuses.forEach(function(status) {