Commit graph

239 commits

Author SHA1 Message Date
Adam Lau
21c0d823dd fix: subdomains should be [] if the host is an ip ()
Closes: 
2016-09-07 16:21:32 +08:00
jongleberry
2abed6ec75 fix: res.flushHeaders() ()
* fix: res.flushHeaders()

* remove arg to flush headers

* fix tests for node v4 and v5
2016-08-10 12:15:48 -07:00
dead_horse
a1cdbdafcf docs: update babel setup
closes 
2016-07-24 01:50:17 +08:00
Yiyu He
23903e7ef4 fix(response): correct response.writable logic () 2016-07-24 01:20:29 +08:00
Yu Qi
c979056087 fix tests on node 6
parsed querystrings no longer inherit from the Object prototype
2016-04-30 09:19:29 +02:00
PlasmaPower
54e58d3523 req: Cache the request IP 2016-04-03 19:30:06 -07:00
jongleberry
be87ef8a24 lint: upgrade packages, fix generator star spacing 2016-03-28 14:21:05 -07:00
Martin Iwanowski
0ac4ff00c6 Convert generator-mw with deprecation warning 2016-03-22 07:35:05 +01:00
dead_horse
39f058e11c fix cookies' secure detect 2016-03-15 13:57:22 -07:00
Lee Bousfield
a440425dc2 Add support for headers in errors 2016-03-12 17:46:35 -07:00
Lee Bousfield
6a147726bd Add support for flushing headers 2016-03-03 21:01:56 -07:00
Yanick Rochon
d134fff9e8 Fix issue when app.use() is called with empty value 2015-11-25 12:10:55 +08:00
jongleberry
65f645d341 use babel-plugin-transform-async-to-generator 2015-11-06 09:40:44 -08:00
jongleberry
eb0bd4c2c3 test: fix use-strict typo 2015-11-06 09:38:00 -08:00
jongleberry
a6547bcbce ⬆️ babel and use async arrow functions 2015-11-05 08:49:20 -08:00
jongleberry
09ada29881 test: add a babel example 2015-11-05 08:47:08 -08:00
dead_horse
08057e386a ensure parseurl always working as expected 2015-11-04 15:08:49 +08:00
broucz
4b1a1da652 test: switch all functions to arrow functions
closes 

Update test: application -> use() should throw if not a function

Fix lint

Use arrow function

Refactor test using arrow function

Remove non mandatory brackets

fix for merge

Fix: missing refactor after merge

Use arrow function for old generator
2015-11-02 11:22:05 -08:00
TJ Holowaychuk
439f051776 Merge pull request from koajs/fix-app-inspect
fix Application.inspect() – missing .proxy value. Closes 
2015-10-31 11:15:09 -07:00
TJ Holowaychuk
308ceee47d Merge pull request from stojanovic/fix/test-todo
Remove TODO from the response type test
2015-10-31 06:10:16 -07:00
Slobodan Stojanovic
275356a5ce Remove TODO from the response type test 2015-10-31 14:01:26 +01:00
blaz
3560651bbc Add usage of koa-convert for legacy middleware
closes 
closes 
2015-10-30 20:20:00 -07:00
TJ Holowaychuk
aa1fbbff4a fix Application.inspect() – missing .proxy value. Closes
fix trailing comma
2015-10-29 09:56:15 -07:00
Slobodan Stojanovic
b08facb7bd Fix indentation and add .eslint rules
closes 
2015-10-29 09:55:34 -07:00
Felix Becker
ebb4850709 Remove co dependency
closes 
closes 

Change tests to use plain functions and promises

Add test

return promise in middleware

Change benchmarks to use plain functions and promises

typeerror
2015-10-27 16:24:25 -07:00
Slobodan Stojanovic
cc1d41f5e3 Refactor tests - add arrow functions
Refactor tests - move .should to the same line as arrow function
2015-10-25 13:26:36 -07:00
broucz
e859c602d1 Update test: application -> use() should throw if not a function
closes 

Fix lint

Use arrow function

Remove not necessary import
2015-10-25 12:53:05 -07:00
jongleberry
2e8cdab8bc support async functions
closes 
closes 
2015-10-22 16:34:59 -07:00
jongleberry
16db0f60c4 eslint: add no-var rule 2015-10-22 15:46:47 -07:00
Santiago Sotomayor
0c438ed435 unset content-type when the type is unknown
closes 
closes 
2015-10-22 15:39:16 -07:00
Michaël Zasso
b5c09a1719 test: fix style issues 2015-10-13 09:23:57 +02:00
Michaël Zasso
24ccde947d add eslint and standard config 2015-10-13 09:23:06 +02:00
TJ Holowaychuk
c06d30286f Merge pull request from tejasmanohar/module_exports
no more exports! only module.exports
2015-10-12 23:46:56 -07:00
Tejas Manohar
46f8d49e4c no more exports! only module.exports 2015-10-13 01:43:23 -05:00
Tejas Manohar
93ade5e2dd refactor Application into a class 2015-10-13 01:19:42 -05:00
Tejas Manohar
e8f79d43f9 modularize tests for application
closes 

add index test for Application

add app.toJSON test

add test for app.inspect()

add tests for app.use()

add tests for app.onerror()

add tests for app.respond()

add tests for app.context()

add tests for app.request()

add tests for app.response

refactor for non-existence of test/app...js

no need for *.js

use helpers/ dir for non-tests
2015-10-12 00:08:06 -07:00
Tejas Manohar
ed19e67055 refactor to use ES6 template strings
replace string interp w/ templates in core

use string templating es6 in benchmarks

template strings in tests dir
2015-10-11 21:22:33 -07:00
Tejas Manohar
9f27c1c414 refactor to use ES6 const
change var to const for static require()'d modules

make constant var references in app use const keyword

refactor context to use es6 constants

refactor request to use es6 constants, let block-scope coming next

use const in response object for static refs

make context tests use es6 constants

experimental unit tests -> const

use const for static references in unit test over req

use const for static refs in res tests

update app tests to use const for static refs

make the context test use es6 constants for static refs

use constants in the README
es6 constants seem to work in --harmony on 0.12 too

use const's for immutable refs in benchmarks

ensure all JS files have blank newline at top

add newline to bottom of file where missing

add a webchat freenode link to irc channel

no need to assign error in catch{}-able test

app.silent option to turn off err logging

keep test env logging for backwards-compat
2015-10-11 21:22:33 -07:00
Tejas Manohar
0b1b49cb8a use strict in all .js files
closes 
2015-10-11 16:08:32 -07:00
fengmk2
f875eb0c30 Merge pull request from tejasmanohar/app_silent
app.silent option to turn off err logging
2015-10-09 11:22:58 +08:00
TJ Holowaychuk
65cc864c9b Merge pull request from tejasmanohar/remove_err_assignment
no need to assign error in catch{}-able test
2015-10-08 14:39:15 -07:00
Tejas Manohar
e717733aa8 no need to assign error in catch{}-able test 2015-10-06 19:43:09 -05:00
Tejas Manohar
5e21238594 add newline to bottom of file where missing 2015-10-05 18:19:32 -05:00
Tejas Manohar
ea4754e332 ensure all JS files have blank newline at top 2015-10-05 18:18:03 -05:00
Tejas Manohar
c369b33b23 app.silent option to turn off err logging 2015-10-05 17:51:26 -05:00
TJ Holowaychuk
1ed691dde3 fix some test formatting 2015-10-02 18:49:20 -07:00
Bryan Bess
0192d21d73 Increase test coverage 2015-10-02 19:18:05 -05:00
Bryan Bess
890244fc74 Fix typo 2015-09-26 09:23:17 -05:00
C.T. Lin
85860587cc implement ctx.origin 2015-09-20 23:49:37 +08:00
Jingwei "John" Liu
b80007c460 fix a possible typo 2015-07-03 18:55:24 +08:00
Yazhong Liu
90b05c09e5 upgrade supertest to ^1.0.1 2015-05-24 12:39:53 +08:00
Aaron Heckmann
6392ee0407 return same object from request.query
Before this change, calling request.query when there was no querystring
resulted in a new object created and returned each time. If the resulting
object was ever changed, accessing request.query would not reflect it and
cause weird bugs.
2015-05-21 12:55:58 -07:00
dead_horse
c8eb5eefb1 make sure helpers return strict string 2015-04-29 01:44:02 +08:00
dead_horse
1c5cb6f691 feat: alias response.headers to response.header 2015-04-23 17:28:31 +08:00
dead_horse
b6aea969f8 non-error thrown, fixed 2015-04-14 10:34:55 +08:00
fengmk2
dd3a0fcdfa make sure req.host and req.hostname return strict string
Should return empty string when no host present.
2015-03-30 17:44:32 +08:00
fengmk2
1edd6ec69a test: improve test coverage for application and response 2015-03-29 14:40:09 +08:00
Jonathan Ong
b721273682 rename 6to5 to babel 2015-02-15 16:47:18 -08:00
Jonathan Ong
c5545cd918 add experimental async function support 2015-02-14 17:33:08 -08:00
Jesús Rodríguez Rodríguez
8d1a340789 Fix typo on response.body test.
Just a small typo.
2015-01-29 15:39:06 -08:00
Jesus Rodriguez
68843e0cb3 Remove unused imports and exports 2015-01-29 15:39:06 -08:00
dead_horse
5a3f32dfdd Add res.append(field, val) to append headers 2015-01-26 02:20:08 +08:00
fengmk2
3e66157472 ctx.request.href: get full request url, include protocol, host and originalUrl
Useful on those scenes need current full request url, like `OAuth`.
2014-12-27 14:17:00 -08:00
HanHor Wu
a04183aae0 remove the 'x-powered-by' in context test since it has been removed 2014-12-08 09:39:51 +08:00
TJ Holowaychuk
e4076ce930 remove x-powered-by. Closes 2014-12-04 01:01:57 -08:00
dead_horse
57eb6a10df set content-type for redirect when accpect plain 2014-11-27 09:25:44 -08:00
Matthew Mueller
6847fe68bd added: ctx.state as the recommended namespace for passing information through middleware and routes. 2014-11-18 00:54:14 -08:00
dead_horse
193eadbdb5 add the missing semicolon 2014-11-16 23:18:37 +08:00
dead_horse
eff4886cd8 ocd 2014-11-16 21:52:14 +08:00
Yoshua Wuyts
9c98440c5c test/application: fix quotes
super minor style thing, but there's not reason not to PR so yeah. haha.
2014-10-31 20:15:45 +01:00
TJ Holowaychuk
eb443d1bee Merge pull request from dead-horse/status
custom status
2014-10-09 09:05:26 -07:00
dead_horse
efdd7d3716 less strict for status, close
add res.message[=]
2014-10-09 23:20:53 +08:00
dead_horse
065a773e65 more test case 2014-10-01 20:42:29 +08:00
Jonathan Ong
2f0fe55ae3 .throw() -> http-errors, .assert() -> http-assert 2014-09-20 10:46:28 -07:00
fengmk2
cca2438f64 ctx.attachment support no-ascii filename 2014-09-19 13:46:08 +08:00
Tiago Ribeiro
a85f580983 Add full coverage 2014-09-08 23:53:46 +01:00
Jonathan Ong
9455726c00 finished -> on-finished
removes the writable test because it’s fake and there are tests for
on-finished for this case
2014-08-16 02:58:06 -07:00
Ian Storm Taylor
dc0c35471c support errors and update docs 2014-08-12 13:22:33 -07:00
Ian Storm Taylor
5931714bd8 make the second argument to throw properly optional 2014-08-12 13:19:14 -07:00
dead_horse
f6626967b2 ignore props.status in ctx.throw 2014-08-09 13:38:54 +08:00
Ian Storm Taylor
bcac468f7c add the ability to pass props to context.throw 2014-08-08 12:37:04 -07:00
TJ Holowaychuk
f9eb219ecf Merge pull request from dead-horse/onerror-status
Onerror status
2014-08-07 19:04:10 -07:00
dead_horse
fa5948cca3 do not expose when err.status not valid 2014-08-08 10:02:24 +08:00
dead_horse
5ca9f451a7 alias request.headers as request.header 2014-08-07 00:04:21 +08:00
dead_horse
e2f61595b8 fix err.status invalid lead to uncaughtException 2014-08-06 21:32:35 +08:00
Jonathan Ong
19a9ef76e5 fix test for new mime-types 2014-08-04 13:28:29 -07:00
dead_horse
5b18f8bab0 parse req.type by media-typer 2014-07-09 23:52:56 +08:00
dead_horse
e791100993 add more test case, fix req.idempotent 2014-07-06 16:52:02 +08:00
Jonathan Ong
31ba115231 res: add .is() 2014-06-13 00:30:59 -07:00
tmilewski
c2322f2b3d remove .status=string 2014-06-10 16:38:25 -04:00
TJ Holowaychuk
63a4297084 Merge pull request from koajs/vary
remove response.append(), use vary module
2014-06-06 23:00:39 -07:00
Jonathan Ong
1a32ecac31 fix res.type= for unknown types
because we changed from mime to mime-types. ideally, we should just not
set the content-type, but this way it’s backwards compatible. we can
change it later.
2014-06-06 16:26:03 -07:00
Jonathan Ong
fdbd16acc3 remove response.append(), use vary module 2014-06-05 16:06:15 -07:00
Jonathan Ong
008f0554c6 set-type -> mime-types
removes mime dependencies from the dep tree.
liberally sets charset because some express users complained about bad
browsers using the default charset.
2014-06-03 21:44:25 -07:00
Jonathan Ong
11cf47c8a6 remove .request accept tests the fail
due to
https://github.com/expressjs/accepts/commit/5975ce464575bd0fddfdd3d41796
958cd6bfc20b. passing nothing into accepts() is silly anyways.
2014-06-03 21:35:11 -07:00
dead_horse
f76268ba58 remove req.host=, fix docs 2014-05-05 12:45:33 +08:00
TJ Holowaychuk
f17629d19f remove .outputErrors, suppress output when handled by the dev. Closes 2014-05-01 16:29:37 -07:00
TJ Holowaychuk
15ab936001 change .status default to 404. Closes 2014-04-28 21:17:46 -07:00
dead_horse
48ac0669c5 fix content-length when body is re-assigned. Closes 2014-04-28 20:34:26 -07:00
dead_horse
6a2ed3e6eb assert object type in ctx.onerror 2014-04-25 08:34:11 +08:00